Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(stdlibs/std)!: remove std.CurrentRealmPath #2087

Merged
merged 45 commits into from
May 23, 2024
Merged

feat(stdlibs/std)!: remove std.CurrentRealmPath #2087

merged 45 commits into from
May 23, 2024

Conversation

linhpn99
Copy link
Contributor

@linhpn99 linhpn99 commented May 13, 2024 •
edited
Loading

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@github-actions github-actions bot added 🧾 package/realm Tag used for new Realms or Packages. 📦 🤖 gnovm Issues or PRs gnovm related labels May 13, 2024
@linhpn99
Copy link
Contributor Author

linhpn99 commented May 13, 2024 •
edited
Loading

this PR relates to #2045

@linhpn99 linhpn99 changed the title deprecate & remove std.CurrentRealmPath() chore(gnovm): deprecate & remove std.CurrentRealmPath() May 13, 2024
@codecov Codecov
Copy link

codecov bot commented May 13, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.02%. Comparing base (e1586a5) to head (5e7f411).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #2087   +/-   ##
=======================================
  Coverage   49.01%   49.02%           
=======================================
  Files         576      576           
  Lines       77604    77578   -26     
=======================================
- Hits        38035    38029    -6     
+ Misses      36486    36467   -19     
+ Partials     3083     3082    -1
Flag Coverage Δ
gnovm 41.93% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@linhpn99
Copy link
Contributor Author

@thehowl hope u give a review

thehowl
thehowl reviewed May 15, 2024
View reviewed changes
gnovm/tests/files/zrealm_std3.gno Outdated Show resolved Hide resolved
gnovm/tests/files/zrealm12.gno Outdated Show resolved Hide resolved
docs/reference/stdlibs/std/testing.md Show resolved Hide resolved
@linhpn99 linhpn99 requested a review from thehowl May 15, 2024 06:40
@Kouteki Kouteki added this to the 🏗4️⃣ test4.gno.land milestone May 15, 2024
@Kouteki Kouteki linked an issue May 15, 2024 that may be closed by this pull request
[GnoVM] Deprecate & remove std.CurrentRealmPath() #2045
Closed
@zivkovicmilos zivkovicmilos added the breaking change Functionality that contains breaking changes label May 15, 2024
@linhpn99
Copy link
Contributor Author

linhpn99 commented May 16, 2024 •
edited
Loading

@thehowl does my PR good enough to approve ?

@michelleellen michelleellen mentioned this pull request May 22, 2024
Open
@thehowl
Copy link
Member

thehowl commented May 23, 2024

LGTM, @gfanton for second review

@linhpn99 linhpn99 requested review from thehowl and gfanton May 23, 2024 08:03
@thehowl thehowl changed the title chore(gnovm): deprecate & remove std.CurrentRealmPath() feat(stdlibs/std)!: remove std.CurrentRealmPath May 23, 2024
@thehowl thehowl merged commit 11649f6 into gnolang:master May 23, 2024
15 checks passed
@Kouteki Kouteki mentioned this pull request May 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thehowl thehowl thehowl approved these changes

@jaekwon jaekwon Awaiting requested review from jaekwon

@deelawn deelawn Awaiting requested review from deelawn

@mvertes mvertes Awaiting requested review from mvertes

@moul moul Awaiting requested review from moul

@ltzmaxwell ltzmaxwell Awaiting requested review from ltzmaxwell

@gfanton gfanton Awaiting requested review from gfanton

Assignees

@linhpn99 linhpn99

Labels
breaking change Functionality that contains breaking changes 📦 🤖 gnovm Issues or PRs gnovm related 🧾 package/realm Tag used for new Realms or Packages.
Projects
💪 Bounties & Worx
Status: Done
🧙‍♂️gno.land core team
Archived in project
Milestone
🏗4️⃣ test4.gno.land
Development

Successfully merging this pull request may close these issues.

[GnoVM] Deprecate & remove std.CurrentRealmPath()
6 participants
@linhpn99 @thehowl @ltzmaxwell @gfanton @Kouteki @zivkovicmilos